[SER] Validate 'reordercoherent' resource property #7429
Merged
+345
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validates: All resources All instructions using resources Rules: 'reordercoherent' may only be used in SM6.9+ in resource handles and resource declarations. Increment/DecrementCounter unsupported on 'reordercoherent' resources. Create a new DXIL 1.9 variant of the 'CompileWhenOkThenCheckRDAT' container test and restore the old one without 'reordercoherent' (pre-microsoft#7250). The validator now rejects 'reordercoherent' in DXIL 1.3 and accepts from DXIL 1.9+. SER implementation tracker: microsoft#7214
tex3d
reviewed
May 6, 2025
tools/clang/test/LitDXILValidation/ser_reordercoherent_invalid_incdec.ll
Outdated
Show resolved
Hide resolved
Co-authored-by: Tex Riddell <[email protected]>
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tex3d
reviewed
May 6, 2025
tex3d
approved these changes
May 6, 2025
tex3d
approved these changes
May 8, 2025
damyanp
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates:
All resources
All instructions using resources
Rules:
'reordercoherent' may only be used in SM6.9+ in resource handles and
resource declarations.
Increment/DecrementCounter unsupported on 'reordercoherent' resources.
Create a new DXIL 1.9 variant of the 'CompileWhenOkThenCheckRDAT' container test and restore the old one without 'reordercoherent' (pre-#7250). The validator now rejects 'reordercoherent' in DXIL 1.3 and accepts from DXIL 1.9+.
SER implementation tracker: #7214